Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a much more accurate labeling system #12

Merged
merged 24 commits into from Nov 4, 2019

Conversation

@JakeMakesStuff
Copy link
Member

JakeMakesStuff commented Nov 4, 2019

Type of Change

  • Tool Source: TS
  • Something else: Better Kubernetes descriptions

What issue does this relate to?

N/A

What should this PR do?

Makes the labeling system far easier to develop for, much less cluttered and allows for overriding of properties.

What are the acceptance criteria?

Does it work? (for me, it does)

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 3afb716 Oct 30, 2019

This commit has been deployed to DigitalOcean Spaces here for easy viewing.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 5082ee0 Oct 30, 2019

This commit has been deployed to DigitalOcean Spaces here for easy viewing.

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on fe2e9cd Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 011c5b9 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on ee01f0b Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 37367cb Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 13a4601 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 9ef7a94 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 184645d Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 7b7f8f2 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 4b3ec73 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 3a02bc2 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 4254929 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 5e1363e Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 00841d3 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff changed the title WIP: Add a much more accurate labeling system Add a much more accurate labeling system Nov 4, 2019
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 4, 2019
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/descriptions/README.md Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/flags.ts Outdated Show resolved Hide resolved
src/kubernetes-tool/utils/kubernetes.ts Show resolved Hide resolved
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on f399f7b Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
@JakeMakesStuff JakeMakesStuff requested a review from MattIPv4 Nov 4, 2019
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 4e6e7f8 Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Sorry Matt, my bad!
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented on 1ca37bb Nov 4, 2019

This commit has been deployed to DigitalOcean Spaces for easy reviewing.

kubernetes-tool
Copy link
Member

MattIPv4 left a comment

Lgtm.

@JakeMakesStuff JakeMakesStuff merged commit b2a897a into master Nov 4, 2019
1 check passed
1 check passed
build
Details
@JakeMakesStuff JakeMakesStuff deleted the labeler branch Nov 4, 2019
MattIPv4 added a commit that referenced this pull request Nov 5, 2019
* write start of labeler codebase

* lint

* more stuff

* Fixes

* Make a copy of the array (this'll be important in the min

* don't return the last label, we can handle undefined properly

* Remove the CRD stuff, I'll deal with this in the min

* Use yaml for k8s data, use JS for importing said data due to TS not understanding other formats

* Don't you just love when stuff works

* Add flags (I have a patch un-commited, I'm testing it rn)

* Plenty of fixes

* This can be undefined

* Change how children are handled

* Finally found a def for service.alpha.kubernetes.io/tolerate-unready-endpoints

* Add statefulset

* More stuff I was trying to figure out

* remove all JSON

* more stuff

* Make case more obvious

* Create Certificate.yml

* move stuff/changes

* forgot to hit ctrl+s

* Actually resolve this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.