This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Add a much more accurate labeling system #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nderstanding other formats
IAmJSD
changed the title
MattIPv4
suggested changes
Nov 4, 2019
Sorry Matt, my bad!
MattIPv4
pushed a commit
that referenced
this pull request
Nov 5, 2019
* write start of labeler codebase * lint * more stuff * Fixes * Make a copy of the array (this'll be important in the min * don't return the last label, we can handle undefined properly * Remove the CRD stuff, I'll deal with this in the min * Use yaml for k8s data, use JS for importing said data due to TS not understanding other formats * Don't you just love when stuff works * Add flags (I have a patch un-commited, I'm testing it rn) * Plenty of fixes * This can be undefined * Change how children are handled * Finally found a def for service.alpha.kubernetes.io/tolerate-unready-endpoints * Add statefulset * More stuff I was trying to figure out * remove all JSON * more stuff * Make case more obvious * Create Certificate.yml * move stuff/changes * forgot to hit ctrl+s * Actually resolve this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
N/A
What should this PR do?
Makes the labeling system far easier to develop for, much less cluttered and allows for overriding of properties.
What are the acceptance criteria?
Does it work? (for me, it does)