Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quotedKeys option to all converters, fixes #9 #14

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

dobromir-hristov
Copy link
Owner

@dobromir-hristov dobromir-hristov commented Jun 21, 2020

Description

This PR allows you to pass an optional quotedKeys parameter, to both CLI and Node API.

This should convert all map keys to quoted values, for SASS, SCSS and Stylus.

tailwindcss-export-config --config=tailwind.config.js --destination=tailwind-variables --format=scss --quoted-keys=true
$fontFamily: (
  "display": (Gilroy,sans-serif),
  "body": (Graphik,sans-serif),
);

$colors: (
  //... other vars
  "pink-700": #b83280,
  "pink-800": #97266d,
  "pink-900": #702459,
  "cyan": #9cdbff,
);

resolves #9

@mpalpha
Copy link

mpalpha commented Jun 22, 2020

Works for me. I would rather have all keys handled the same way like this since it is considered a best practice, and I would be able to use the same logic for all key names within loops.

@dobromir-hristov dobromir-hristov merged commit 3439685 into master Jun 23, 2020
@dobromir-hristov dobromir-hristov deleted the feat/allow-optional-quoted-keys branch June 23, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote map keys (Scss)
2 participants