Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define width and height #41

Closed
chou666 opened this issue Apr 27, 2020 · 5 comments
Closed

Do not define width and height #41

chou666 opened this issue Apr 27, 2020 · 5 comments

Comments

@chou666
Copy link

chou666 commented Apr 27, 2020

In my case, I want to have the iframe with width="100%" and height="100%" ( or to be manage in CSS). But the width and height are sent to the player, the value id 100px

For backwards compatibility, defined width and height option of the player only if not null

@HarwinBorger
Copy link

HarwinBorger commented Apr 28, 2020

Great component, compliments for that.

I have the same issue as @chou666 mentioned, i would like to have no width/height set.

And or those options would be nice:
player-width="100%" player-height="100%"
and / or
player-width="false" player-height="false"
player-width="" player-height=""

@dobromir-hristov
Copy link
Owner

If not provided, the player will fallback to the max widht and height that the Video Supports, is that what you want?

@dobromir-hristov
Copy link
Owner

If you want a responsive player, you would have to do some CSS magic in any case, a bit of position absolute here and there and aspect ratios

@Rhovian
Copy link

Rhovian commented Apr 28, 2020

setting the responsive option to true helped me solve this
:options="{responsive: true}"

@chou666
Copy link
Author

chou666 commented May 1, 2020

Many thanks to @Mjavala for yout tips !

This solve my problem:

In data section:

            vimeoOptions: {
                responsive: true,
                width: "1000",
                height: "100%",
            },

In template:

            <vue-vimeo-player
                :video-id="video"
                :video-url="video"
                :height="'100%'"
                :width="'100%'"
                :client-height="'100%'"
                :client-width="'100%'"
                :options="vimeoOptions"
            />

@chou666 chou666 closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants