-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added Office plugin for Asciidoctorj #557
base: master
Are you sure you want to change the base?
Conversation
I tried to read and undestand the logs, but something strange happened here. So I just triggered the build again to see if it maybe was just a hickup |
no hickup :-( |
so, it seems that these tests really fail. This seems to be the root cause:
|
so, it seems that the plugin brings its own dependencie to asciidoctorj along. Can you please try to specify the dependency as follows:
this turns the tests at least to green, but I don't know if the plugin then still works. |
Thank you, Ralf, for analyzing this. I'll have a look at what happens now. |
Could you already test if the extension still works? |
Not yet, I was in a training the whole day. However, I made it compile and test, then I committed it. How can I easily test it on a new document that contains the |
ok. I will try to test it... hold on... |
hm. I cloned docToolchain and added to the file
I then did a |
Hi guys, please use the version 0.0.1-alpha.2 this is the latest version. I have to invest some time to move away from bintray to maven central. |
scripts/AsciiDocBasics.gradle
Outdated
// See https://github.com/uniqueck/asciidoctorj-office-extension | ||
// asciidoctor 'com.uniqueck:asciidoctorj-office-extension:0.0.1-alpha' | ||
// https://mvnrepository.com/artifact/org.uniqueck/asciidoctorj-office-extension | ||
asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') { | |
asciidoctor (group: 'com.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha.2') { |
Hi @uniqueck Constantin, thanks for the tip and the offer to help, appreciate this! I tried to use the version that you suggested but unfortunately, it is not in the Maven jcenter repository. See here: https://mvnrepository.com/artifact/org.uniqueck/asciidoctorj-office-extension Could you have a look, why this is so? |
Hi @mattes3, i realize this also yesterday for my example repostiory. I don't know why this is only for this extension a problem. As a workaround I added this following to the repositories sections.
Please also accept the suggested code above, because the groupId differs between this versions. |
I check this and define it as a provided dependency. |
@uniqueck Hi Constantin, I have made your changes but the build still breaks. Can you have a look? |
|
This extension is now in maven central available. Please have a look at the issue #556 for more details. You have to change the groupId to de.uniqueck.asciidotorj.extensions and the first new release version is 0.1.0. The reference to bintray and jcenter can be removed. Let me know if this helps. |
Now the tests run fine. added to the file
I then did a @uniqueck, could you check if you can find out why nothing happens? |
This extension needs asciidoctorj 2.1.0. I have to check if i can downgrade these dependencies. For the meanwhile you can check this working example. https://github.com/uniqueck/asciidoctorj-extension-gradle-example |
@rdmueller is it for doctoolchain possible to update asciidoctorj to a version greater or equal to 2.1.0? |
@uniqueck - that's on my list. But not for the 1.3.x version - only for the 2.0.x which is currently under heavy developtment (ng-branch) |
We upgraded to asciidoctorj 2.5.7. The question is if this feature is still needed/requested. Otherwise I would close the PR until someone needs it. |
it is still a great feature, let's see if @uniqueck will find some time to work on it. |
What is open? Is there a bug? |
In 2021, this was important to my clients. Now in 2023, it would still be great to have. |
Probably nothing from the plugin side. This PR was started by @mattes3 but was blocked since docToolchain used an outdated asciidoctorj plugin. Now we upgraded to the latest asciidoctorj plugin and I wanted to know if someone is willing to stand up and finish it. Since there is not much code (know-how) in the PR I would rather close it than people believing someone is working on the feature but in reality nothing happens. |
So are we sure that all is working as expected? |
@uniqueck , no I guess nobody has tested it yet. I thought there are still things to change/implement after we've uodated the asciidoctor version. Afaik, the powerpoint support by this plugin is better than what we currently have (works on linux). So I still think this plugin would be nice to have... |
Ok I will check this and ask for some help if I stuck. |
Ok I'm completely lost in this gradle stuff, where I have to declare external dependencies for my extension, so that the asciidoctorj task register thie extension and I can use the slide block macro. I thought the goal of doctoolchain ng was, make all a little bit simpler. I tried to defined a configuration for asciidcoctorExtensions and add this configuration to dependencies with my office extension. |
The second thing I realized, is that the PR points to the wrong target branch, or I'm wrong? I need asciidoctorj 2.x for this extension, so we have to relocate it to the ng branch. I think we have to provide a documentation part, how someone can add an own asciidoctorj extension for |
PLEASE DO NOT MERGE THIS PULL REQUEST, YET!
I need help because the one-liner that I added breaks the existing tests. Could you please have a look why this happens?
Thank you,
Matthias