-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: more robust method to detect duplicate index #1651
Conversation
…07/refactor-duplicate-index
ef6e251
to
c57d576
Compare
@JoanFM @JohannesMessner mypy and black is failing on files I did not modify and I already pulled from main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess u need to commit pyproject
updated and not only poetry.lock
?
the pyproject.toml file already has what I want when I pulled from main i.e.:
I don't know if this is the expected behavior, but after the pull, I ran |
Not sure, but in that case, I would not update the |
Why is there a need to update the lock file ? Not sure that I follow |
This reverts commit eb3c3d2.
…07/refactor-duplicate-index
24aece2
to
fb48a40
Compare
when I pull from upstream/main, I noticed there was a change in my pyproject.toml so I ran I've updated the PR so that the lock file here matches upstream/main too. |
fixes #1357