Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more robust method to detect duplicate index #1651

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

hsm207
Copy link
Collaborator

@hsm207 hsm207 commented Jun 15, 2023

fixes #1357

@JoanFM JoanFM closed this Jun 15, 2023
@JoanFM JoanFM reopened this Jun 15, 2023
@hsm207 hsm207 force-pushed the hsm207/refactor-duplicate-index branch from ef6e251 to c57d576 Compare July 10, 2023 10:26
@hsm207 hsm207 marked this pull request as ready for review July 10, 2023 10:38
@hsm207
Copy link
Collaborator Author

hsm207 commented Jul 10, 2023

@JoanFM @JohannesMessner mypy and black is failing on files I did not modify and I already pulled from main

@hsm207 hsm207 enabled auto-merge (squash) July 10, 2023 10:42
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess u need to commit pyproject updated and not only poetry.lock?

@hsm207
Copy link
Collaborator Author

hsm207 commented Jul 10, 2023

I guess u need to commit pyproject updated and not only poetry.lock?

the pyproject.toml file already has what I want when I pulled from main i.e.:

weaviate-client = {version = ">=3.17, <3.18", optional = true}

I don't know if this is the expected behavior, but after the pull, I ran poetry lock --no-update and surprisingly there were changes to the poetry.lock file.

@JoanFM
Copy link
Member

JoanFM commented Jul 10, 2023

Not sure, but in that case, I would not update the poetry.lock. @samsja may know better about the common usage pattern here

@samsja
Copy link
Member

samsja commented Jul 10, 2023

Why is there a need to update the lock file ? Not sure that I follow

@hsm207 hsm207 force-pushed the hsm207/refactor-duplicate-index branch from 24aece2 to fb48a40 Compare July 10, 2023 15:49
@hsm207
Copy link
Collaborator Author

hsm207 commented Jul 10, 2023

Why is there a need to update the lock file ?

when I pull from upstream/main, I noticed there was a change in my pyproject.toml so I ran poetry lock --no-update.

I've updated the PR so that the lock file here matches upstream/main too.

@hsm207 hsm207 merged commit 0a1da30 into docarray:main Jul 10, 2023
19 of 22 checks passed
@hsm207 hsm207 deleted the hsm207/refactor-duplicate-index branch July 10, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weaviate: Add more robust method to detect existing index
3 participants