Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding field descriptions to predefined point cloud 3D document #1792

Conversation

punndcoder28
Copy link
Contributor

Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
@punndcoder28 punndcoder28 marked this pull request as ready for review September 15, 2023 16:33
@punndcoder28
Copy link
Contributor Author

@JoanFM This PR addresses the changes to add field descriptions and examples for PointCloud3D document

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.90% ⚠️

Comparison is base (4ef4939) 81.60% compared to head (9235dbd) 79.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   81.60%   79.70%   -1.90%     
==========================================
  Files         136      136              
  Lines        9044     9045       +1     
==========================================
- Hits         7380     7209     -171     
- Misses       1664     1836     +172     
Flag Coverage Δ
docarray 79.70% <100.00%> (-1.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/documents/point_cloud/point_cloud_3d.py 92.30% <100.00%> (+0.30%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM merged commit 18d3afc into docarray:main Sep 15, 2023
6 checks passed
@JoanFM JoanFM mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants