-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep _metadata when serializing to dict and json #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 86.62% 86.61% -0.02%
==========================================
Files 134 134
Lines 6477 6486 +9
==========================================
+ Hits 5611 5618 +7
- Misses 866 868 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
requested changes
Jul 18, 2022
JoanFM
reviewed
Jul 18, 2022
JoanFM
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is the root cause of multi-modal documents not working after being (de)serilaized from/to json or dict.
Details here: #429
Better multi-modal support (#425) partially depends on this.
There seems to be no super elegant way of solving this with pydantic, based on this and this.
I see two options:
_metadata
->metadata
_metadata
manuallyIn order not to change the pydantic model of
Document
, this PR implements option 2.