-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Alpine as root image #795
Conversation
Thank you @harmw . I was suprised that the images are small(backend: 1.22GB -> 215MB, frontend: 1.25GB -> 479MB) By the way, I executed the following docker-compose command. The build was successful but the running was failed:
There may be a problem in backend. As a result, nginx container exited with code 1. My environment:
|
hm, did I miss that somewhere? Things on my end just worked, given not using |
When I changed Dockerfile and run.sh, it works fine. Dockerfile(install bash)
run.sh
But I don't want to change run.sh as much as possible. |
That's not what you got, let me check if maybe I got some outdated containers dangling around 🤔 Let me try again and start with a wipe of my docker-box. --edit--
BAM, now let me fix that :) |
Pip3 doesn't need to be symlinked as the creation of /usr/bin/pip is done through installation of setuptools (or the pip upgrade).
should be fine now 👍 |
Thanks! It works fine. |
🎉 @harmw , can we clean cache? |
@kuraga it doesn't seem to be caching 🙈
As this branch got merged, if it's okay with you, let's create a separate issue about better cache cleaning (if any) - should that be required 👍 |
This supports #794 , though right now it only works for the main backend/frontend containers. I haven't looked at the supporting stuff, like something mssql I noticed :)