Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add centos7-devtoolset7-gcc7 image #65

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

sjh26
Copy link
Contributor

@sjh26 sjh26 commented Oct 30, 2020

Add CentOS 7 image with gcc7.

Copy link
Member

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution.

After updating the tip level README, it will be good for integration.

@sjh26
Copy link
Contributor Author

sjh26 commented Nov 3, 2020

Added info to readme. Also, I am not sure the correct way to handle the dockbuild/centos7:latest tag. It was/is associated with the centos7-gcc5 build. Should it be moved to the gcc7 build? The gcc5 build will still be in use, we aren't removing it.

@sjh26 sjh26 requested a review from jcfr November 3, 2020 18:33
@sjh26
Copy link
Contributor Author

sjh26 commented Nov 10, 2020

@jcfr can this be merged?

@jcfr jcfr merged commit c8d0b72 into dockbuild:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants