-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update consul api and Token support in Consul #1434
Conversation
ping @abronan |
Hi @ch3lo, thanks for the contribution. ACL is a new feature of Consul I'm unsure whether we should merge this now or wait a little bit. I also need to test Consul |
Sounds good, tell me if I can help. Regards |
@ch3lo Thanks. Let's wait for the official release of Consul 0.6 (which is still in RC phase) and update the docs accordingly to mention that ACL is a new feature in Consul 0.6 :) |
Hey @ch3lo, Otherwise LGTM, seems like |
sure I can. Good news :) |
2ebad04
to
744e3a3
Compare
123ea20
to
744e3a3
Compare
yep Im having conflicts with amend. Sorry |
@ch3lo something is still not right in your godep |
@ch3lo can you please squash your commits ? |
Signed-off-by: Marcelo Salazar R <chelosalazar@gmail.com>
1a5988e
to
b9ffff1
Compare
@ch3lo I'm not quite sure what this does now and why we would need a dependency on |
With this update is possible to use ACL Token in the Consul backend, because the new Consul API uses the CONSUL_HTTP_TOKEN environment to setup a default token in the initializer. I think this solution is better than use the anonymous token with the needed permissions.
Regards