Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Update consul api and Token support in Consul #1434

Closed
wants to merge 1 commit into from

Conversation

ch3lo
Copy link
Contributor

@ch3lo ch3lo commented Nov 19, 2015

With this update is possible to use ACL Token in the Consul backend, because the new Consul API uses the CONSUL_HTTP_TOKEN environment to setup a default token in the initializer. I think this solution is better than use the anonymous token with the needed permissions.

Regards

@aluzzardi
Copy link
Contributor

ping @abronan

@abronan
Copy link
Contributor

abronan commented Nov 23, 2015

Hi @ch3lo, thanks for the contribution. ACL is a new feature of Consul 0.6 which is not released yet so this should be documented somehow.

I'm unsure whether we should merge this now or wait a little bit. I also need to test Consul 0.6 with libkv, even if the tests appears to be fine.

@ch3lo
Copy link
Contributor Author

ch3lo commented Nov 27, 2015

Sounds good, tell me if I can help.

Regards

@abronan
Copy link
Contributor

abronan commented Nov 30, 2015

@ch3lo Thanks. Let's wait for the official release of Consul 0.6 (which is still in RC phase) and update the docs accordingly to mention that ACL is a new feature in Consul 0.6 :)

@abronan
Copy link
Contributor

abronan commented Dec 8, 2015

Hey @ch3lo, 0.6.0 is out now, is it possible to update this PR to include it in the Godeps instead of v0.6.0-rc2? Thanks!

Otherwise LGTM, seems like CONSUL_HTTP_TOKEN was there before 0.6.0, good to know! :)

@ch3lo
Copy link
Contributor Author

ch3lo commented Dec 10, 2015

sure I can. Good news :)

@ch3lo
Copy link
Contributor Author

ch3lo commented Dec 11, 2015

yep Im having conflicts with amend. Sorry

@ch3lo ch3lo reopened this Dec 11, 2015
@vieux
Copy link
Contributor

vieux commented Dec 11, 2015

@ch3lo something is still not right in your godep

@vieux
Copy link
Contributor

vieux commented Dec 12, 2015

@ch3lo can you please squash your commits ?

Signed-off-by: Marcelo Salazar R <chelosalazar@gmail.com>
@abronan
Copy link
Contributor

abronan commented Dec 17, 2015

@ch3lo I'm not quite sure what this does now and why we would need a dependency on serf/coordinate or goclean-http. It also seems that Consul API version is still 0.5.0 in Godeps. Can you update the PR in its old state, but just doing a godep update on github.com/hashicorp/consul/api (making sure it's checked out in your go env to v0.6.0)? Let me know if I'm missing something obvious. Thanks!

@suryagaddipati suryagaddipati mentioned this pull request Jan 2, 2016
@abronan
Copy link
Contributor

abronan commented Jan 15, 2016

Closing as this was updated by #1589.

Thanks for opening this one in the first place @ch3lo!

@abronan abronan closed this Jan 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants