Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03] Windows: disable flaky test TestStartReturnCorrectExitCode #419

Merged
merged 1 commit into from
Nov 1, 2019
Merged

[19.03] Windows: disable flaky test TestStartReturnCorrectExitCode #419

merged 1 commit into from
Nov 1, 2019

Conversation

andrewhsu
Copy link

The 19.03 branch has failures on the tests run after PR merges:

--- FAIL: TestDockerSuite/TestStartReturnCorrectExitCode (9.39s)
    docker_cli_start_test.go:198: assertion failed: 125 (exitCode int) != 12 (int): out: time="2019-10-30T18:28:20Z" level=error msg="error waiting for container: EOF"

This PR is a clean backport of PR moby#40117

@andrewhsu
Windows: disable flaky test TestStartReturnCorrectExitCode
031ef2d 
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit 1be272e)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 19.03.5 milestone Oct 31, 2019
thaJeztah
thaJeztah approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 35913e5 into docker-archive:19.03 Nov 1, 2019
@andrewhsu andrewhsu deleted the xit branch November 1, 2019 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
19.03.5
2 participants
@andrewhsu @thaJeztah