-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: disable flaky test TestStartReturnCorrectExitCode #40117
Conversation
Is this both RS1 and RS5, or only RS1 ? |
I've only seen this flaky test a big issue on RS1. |
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i should have started this as a draft PR to run the RS1 tests. i'm putting this to WIP so i can get a temp git commit in to twiddle RS1 tests. |
oh right, i can't make changes to jenkinsfile. @thaJeztah can you carry this PR? |
@andrewhsu no need to modify the Jenkinsfile; just check the |
From the most recent PR check with 1be272e looks like the
And not skipped for RS5:
Only the ppc64le unit test failing because of memory allocate failure:
I've rekicked PR check to only run the ppc64le tests and taken the ppc64le node offline so a different one can be used. |
I think all the powerpc nodes have 4GB, or are there that have more?
|
That guy again 😂 |
The ppc64le checks are now also green. I think this PR is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM
Kicked CI again; some weird error while building the image on RS5
|
Of the past 25 test runs on
master
branch, I can count at least 10 failures that are related to this test on windows: https://ci.docker.com/public/blue/organizations/jenkins/moby/activity?branch=masterDisabling this test similar to #39945
Related tracking issue: #38521
cc @ddebroy @vikramhh