Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: disable flaky test TestStartReturnCorrectExitCode #40117

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Windows: disable flaky test TestStartReturnCorrectExitCode #40117

merged 1 commit into from
Oct 22, 2019

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Oct 21, 2019

Of the past 25 test runs on master branch, I can count at least 10 failures that are related to this test on windows: https://ci.docker.com/public/blue/organizations/jenkins/moby/activity?branch=master

Disabling this test similar to #39945

Related tracking issue: #38521

cc @ddebroy @vikramhh

@thaJeztah
Copy link
Member

Is this both RS1 and RS5, or only RS1 ?

@andrewhsu
Copy link
Member Author

I've only seen this flaky test a big issue on RS1.

Improving CI automation moved this from In progress to Review in progress Oct 21, 2019
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Improving CI automation moved this from Review in progress to Reviewer approved Oct 21, 2019
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Member Author

i should have started this as a draft PR to run the RS1 tests. i'm putting this to WIP so i can get a temp git commit in to twiddle RS1 tests.

@andrewhsu andrewhsu changed the title Windows: disable flaky test TestStartReturnCorrectExitCode WIP Windows: disable flaky test TestStartReturnCorrectExitCode Oct 21, 2019
@andrewhsu
Copy link
Member Author

oh right, i can't make changes to jenkinsfile. @thaJeztah can you carry this PR?

@thaJeztah
Copy link
Member

@andrewhsu no need to modify the Jenkinsfile; just check the windowsRS1 checkbox when starting a rebuild

@andrewhsu
Copy link
Member Author

From the most recent PR check with 1be272e looks like the TestStartReturnCorrectExitCode test is skipped on RS1:

--- SKIP: TestDockerSuite/TestStartReturnCorrectExitCode (0.01s)
    docker_cli_start_test.go:200: FLAKY on Windows RS1, see #38521

And not skipped for RS5:

--- PASS: TestDockerSuite/TestStartReturnCorrectExitCode (6.54s)

Only the ppc64le unit test failing because of memory allocate failure:

# github.com/docker/docker/daemon/cluster/executor/container.test
/usr/local/go/pkg/tool/linux_ppc64le/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

I've rekicked PR check to only run the ppc64le tests and taken the ppc64le node offline so a different one can be used.

@thaJeztah
Copy link
Member

I think all the powerpc nodes have 4GB, or are there that have more?

Total Memory: 3.976GiB

@thaJeztah
Copy link
Member

Could not connect to ppc64le-ubuntu-13 to send interrupt signal to process
Aborted by Peter Salvatore

That guy again 😂

@andrewhsu andrewhsu changed the title WIP Windows: disable flaky test TestStartReturnCorrectExitCode Windows: disable flaky test TestStartReturnCorrectExitCode Oct 21, 2019
@andrewhsu
Copy link
Member Author

andrewhsu commented Oct 21, 2019

The ppc64le checks are now also green. I think this PR is ready to go.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@thaJeztah
Copy link
Member

Kicked CI again; some weird error while building the image on RS5

 ERROR: make.ps1 failed:
The decryption operation failed, see inner exception.
 At C:\gopath\src\github.com\docker\docker\hack\make.ps1:440 char:13
+             Invoke-WebRequest $url -OutFile "docker.zip"
 +             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@thaJeztah thaJeztah merged commit 248c136 into moby:master Oct 22, 2019
Improving CI automation moved this from Reviewer approved to Done Oct 22, 2019
@andrewhsu andrewhsu deleted the x branch October 22, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Improving CI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants