Additional groups lookup #559
Conversation
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
|
@tianon PTAL :) |
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
mrunalp
force-pushed
the
add_groups_lookup
branch
from
ba2bb44
to
45046ec
Compare
| if err != nil { | ||
| return nil, fmt.Errorf("Failed to open group file: %v", err) | ||
| } | ||
| defer groupReader.Close() |
There was a problem hiding this comment.
i think groupPath can be opened once and reused after.
|
ping @mrunalp :) |
|
Am out sick :( hopefully next week Sent from my iPhone
|
|
@mrunalp I have some free time ! I can send you some improvements of this if you dont mind. |
|
Sure, go for it. Thanks. Sent from my iPhone
|
|
Closing in favor of #603 |
This PR modifies AdditionalGroups to be a string array and the lookup to translate to group ids is performed in the container as discussed in moby/moby#10717
Signed-off-by: Mrunal Patel mrunalp@gmail.com