V1 of Pulpo #1
V1 of Pulpo #1
Conversation
added readme reset tests
added boolean and string type casting
cleaned out cached js files added options for schema
added required check removed eslint since it is ineffective added undefined checks for transform and cast to prevent errors
| ], | ||
| "testRegex": "/test/.*\\.spec\\.(ts|tsx)$" | ||
| }, | ||
| "dependencies": { |
|
Minor clarifications. I saw the demo last week. Can't wait to see this in action in https://github.com/docker/bonito and our CLI/Platform come to fruition. |
|
Would you need to be logged in as a specific user to be able to use |
| ### Definition | ||
| A property is comprised of the following keyed values: | ||
|
|
||
| * **description** (*required string*) - a to define the purpose of the property |
There was a problem hiding this comment.
(how do you select a single line for comment?)
|
@kyhy yea, in the beginning you will need to be part of the |
| "tsx", | ||
| "js" | ||
| ], | ||
| "testRegex": "/test/.*\\.spec\\.(ts|tsx)$" |
There was a problem hiding this comment.
moduleFileExtensions seem to be ts, tsx and js. Should the testRegex also check for js? Or does it handle js extensions automatically? "testRegex": "/test/.*\\.spec\\.(ts|tsx|js)$"
There was a problem hiding this comment.
we explicitly do not want to run any JS files found since most of the editor add-ons for typescript will compile the files in the same directory while working, so we only want to pay attention to our original source files
…po in readme, scoped npm module name to @bonito
| "files": [ | ||
| "src/index.ts" | ||
| ] | ||
| } |
|
is this branch using Typescript Definition Manager? Kind of over my head. Otherwise, LGTM with minor comments. Can't wait to use bonito! |
|
@kyhy - yup, we are using the typings npm for this guy |
This branch now fully meets the expectations of the README for the defined interface and functionality. Please review ASAP and give feedback so we can integrate back into the Bonito project.