-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need enable embed SAPI #510
Comments
Going to need a lot more context, especially since Google isn't being terribly helpful in telling me what "embed SAPI" is, and I'm not familiar with it. Is this something that would need to be enabled in the images by default? What's the primary use case? How does one use it? Is it an extension that could be compiled against an already-compiled PHP installation? There's simply not enough information here for us to help, sorry! |
From what I can find, https://packages.debian.org/stretch/libphp7.0-embed is how Debian provides this functionality, which is a package to link your application against |
you are right about linking against libphp.so. example - https://unit.nginx.org/installation/ wants this binding. my working scenario here: master...fizzka:add-embed |
Seems like a sane approach -- what's the image size impact (before & after)? Btw, I just pushed up ed0b10e so you can drop |
Hello! Embed SAFI is needed for anything that links with the running PHP library. As said before, NGINX and uWSGI applications need this but any other application that needs libphp also needs this enabled. The "cost" is an additional .so inside the image. In a multi-stage build, libphp allows ABI compatibility when the user needs to use a custom binary in conjunction with PHP application. That said, may @tianon reopen this issue and consider add the |
See #1104 😉 |
Hello @tianon I saw the PR #1104 but it only applies for CLI images. PHP ZTS is required to use pthreads with PHP so not only CLI image may require the additional libphp, but also ZTS as long it's more likely an application that uses pthreads needs dynamic linking into PHP.. Can you please accept the PR #1175 as @ygormutti asked for merge and keep ZTS and CLI with |
Disclaimer: me and @leleobhz both work for the same company :) |
Need enable embed SAPI
The text was updated successfully, but these errors were encountered: