Add "--enable-embed" to Debian-based ZTS variants #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
yes, zts should be the same as CLI except thread safety (ZTS) would be great if this can be for all images (incl. Alpine), as nginx is supported on Alpine as well and we use it without any issues |
|
@mvorisek, please see this comment regarding alpine and SAPI |
I read it already, but there should be really no reason between cli image for Debian/Alpine in sense of the php binary build |
ygormutti
force-pushed
the
enable-embed-on-zts
branch
from
73d7aa1
to
c9fc593
Compare
|
Sorry for the delay -- after more thought, I agree this makes sense. I've rolled it into #1208 where it can be a bit more explicit. 😅 |
This was referenced Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1104 added the flag to Debian-based CLI variants; we use a Debian-based ZTS variant, and would benefit from this flag as well.
Also, NGiNX Unit, the use case scenario mentioned in #1104 seems to be compatible with ZTS.
Refs #510 #939