Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable embed also on fpm on non zts #1358

Conversation

DracoBlue
Copy link

@DracoBlue DracoBlue commented Dec 14, 2022

EDIT 2023/06/25: for those searching for something like this: we rolled our own based on the official alpine packages for php at https://github.com/Endava/docker-php/tree/release/8.2-zts (it supports php 8.2 with zts and following).

#1104 added the flag to Debian-based CLI variants; in #1175 was this added for debian based ZTS variants. we use an alpine-based non-zts variant, and would benefit from this flag as well.

Also, NGiNX Unit, the use case scenario mentioned in #1104 - seems to work with ubuntu, but lacks alpine support because of missing embed in cli docker image. In #1355 (comment) it was requested to not add this flag to keep alpine cli image small, thus the idea is here to do it with the fpm image instead.

Refs #510 #939 #1175 #1355

@DracoBlue
Copy link
Author

Update from 2023/06/25: For those searching for something like this: we rolled our own based on the official alpine packages for php (but adjusted so that we get zts builds) at https://github.com/Endava/docker-php/tree/release/8.2-zts (it supports php 8.2 with zts and following).

@DracoBlue DracoBlue closed this Jun 25, 2023
@DracoBlue DracoBlue deleted the enable-embed-on-alpine-fpm-non-zts branch June 25, 2023 19:54
jaydrogers added a commit to serversideup/docker-php that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants