Merge PHP_EXTRA_* into the places they're used #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, this explicitly treats "cli" and "zts" variants as similar for the purposes of `--enable-embed`.
mvorisek
reviewed
Oct 9, 2021
| \ | ||
| --disable-cgi \ | ||
| {{ ) end -}} | ||
| {{ if (env.variant == "cli" or env.variant == "zts") and (is_alpine | not) then ( -}} |
There was a problem hiding this comment.
Suggested change
| {{ if (env.variant == "cli" or env.variant == "zts") and (is_alpine | not) then ( -}} | |
| {{ if (env.variant == "cli" or env.variant == "zts") then ( -}} |
There was a problem hiding this comment.
I'm less convinced there -- it's a ~14MB increase. On the Debian-based images, we're on the order of almost 500MB already, so another 14 is pretty negligible in comparison. On Alpine, we're currently at ~84MB, so this would be a pretty noticeable increase in overall image size.
yosifkit
approved these changes
Oct 11, 2021
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 12, 2021
Changes: - docker-library/php@1e6fd3b: Merge pull request docker-library/php#1208 from infosiftr/extra-extra - docker-library/php@6d7ea20: Merge PHP_EXTRA_* into the places they're used
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 13, 2021
Changes: - docker-library/php@15ddd64: Merge pull request docker-library/php#1213 from infosiftr/strip-ext - docker-library/php@d7f4627: Merge pull request docker-library/php#1212 from infosiftr/find-perm - docker-library/php@b2c6b85: Add stripping to installed extensions - docker-library/php@6e558df: Fix "find -perm" syntax (and ignore "strip" failures but not "find" failures) - docker-library/php@1e6fd3b: Merge pull request docker-library/php#1208 from infosiftr/extra-extra - docker-library/php@6d7ea20: Merge PHP_EXTRA_* into the places they're used
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 14, 2021
Changes: - docker-library/php@505d866: Update 8.1-rc to 8.1.0RC4 - docker-library/php@15ddd64: Merge pull request docker-library/php#1213 from infosiftr/strip-ext - docker-library/php@d7f4627: Merge pull request docker-library/php#1212 from infosiftr/find-perm - docker-library/php@b2c6b85: Add stripping to installed extensions - docker-library/php@6e558df: Fix "find -perm" syntax (and ignore "strip" failures but not "find" failures) - docker-library/php@1e6fd3b: Merge pull request docker-library/php#1208 from infosiftr/extra-extra - docker-library/php@6d7ea20: Merge PHP_EXTRA_* into the places they're used
NeilHanlon
pushed a commit
to NeilHanlon/official-images
that referenced
this pull request
Oct 27, 2021
Changes: - docker-library/php@505d866: Update 8.1-rc to 8.1.0RC4 - docker-library/php@15ddd64: Merge pull request docker-library/php#1213 from infosiftr/strip-ext - docker-library/php@d7f4627: Merge pull request docker-library/php#1212 from infosiftr/find-perm - docker-library/php@b2c6b85: Add stripping to installed extensions - docker-library/php@6e558df: Fix "find -perm" syntax (and ignore "strip" failures but not "find" failures) - docker-library/php@1e6fd3b: Merge pull request docker-library/php#1208 from infosiftr/extra-extra - docker-library/php@6d7ea20: Merge PHP_EXTRA_* into the places they're used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this explicitly treats "cli" and "zts" variants as similar for the purposes of
--enable-embed.This is a continuation / follow-up for #1193.
Closes #1175