Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debian:bookworm #415

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add debian:bookworm #415

merged 1 commit into from
Jun 13, 2023

Conversation

sitano
Copy link
Contributor

@sitano sitano commented Apr 5, 2023 •
edited
Loading

bookworm distro for different Ruby versions + 2.7.8 support

@tianon
Copy link
Member

tianon commented Apr 5, 2023

See also docker-library/golang#456 (comment)

@ojab
Copy link
Contributor

ojab commented Jun 13, 2023

Bump since it was released https://www.debian.org/News/2023/20230610

ojab
ojab reviewed Jun 13, 2023
View reviewed changes
versions.json Outdated
Comment on lines 9 to 10
"buster",
"slim-buster",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess buster should be removed per #357 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojab should I remove buster lines though?

@sitano
Copy link
Contributor Author

sitano commented Jun 13, 2023

I have rebased the branch to fix conflicts.
At the moment it does not compile with apline17 and 18 due to openssl version iirc, but not remember for sure.
update.sh breaks versions.json for 2.7, I am not sure if I need to fix this script and what it does at all.

@ojab
Copy link
Contributor

ojab commented Jun 13, 2023

I believe the single change should be

diff --git a/versions.sh b/versions.sh
index 0901026..6848b79 100755
--- a/versions.sh
+++ b/versions.sh
@@ -70,8 +70,8 @@ for version in "${versions[@]}"; do
                        sha256: env.shaVal,
                        variants: [
                                (
+                                       "bookworm",
                                        "bullseye",
-                                       "buster",
                                        empty # trailing comma hack
                                | ., "slim-" + .), # https://github.com/docker-library/ruby/pull/142#issuecomment-320012893
                                (

and everything else should be autogenerated by ./update.sh (don't see any special cases for buster, so nothing else to remove + dunno why need_openssl flag is needed).

(NB: I'm not a maintainer)

@ojab
Copy link
Contributor

ojab commented Jun 13, 2023

Ah, missed + 2.7.8 support part. Also shouldn't be here, it's EOLed/unsupported and was dropped because of that.

@yosifkit
Copy link
Member

yosifkit commented Jun 13, 2023 •
edited
Loading

Force pushed to drop out Ruby 2.7 and buster; also added same fix as docker-library/python#822 (comment).

Edit: kept buster for Ruby 3.0 since it doesn't support OpenSSL 3.

@sitano @yosifkit
Add debian:bookworm, drop buster
ed1be47 
Signed-off-by: Ivan Prisyazhnyy <john.koepi@gmail.com>
@tianon tianon merged commit 65c8de9 into docker-library:master Jun 13, 2023
25 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 13, 2023
@docker-library-bot
Update ruby
ee693b5 
Changes:

- docker-library/ruby@65c8de9: Merge pull request docker-library/ruby#415 from sitano/ivan_ruby_bookworm
- docker-library/ruby@ed1be47: Add debian:bookworm, drop buster
@sitano sitano deleted the ivan_ruby_bookworm branch June 14, 2023 10:43
@sitano
Copy link
Contributor Author

sitano commented Jun 14, 2023 •
edited
Loading

Thank you for accepting this PR!
You would be surprised how many people still sit on 2.7.x.

@tianon tianon mentioned this pull request Jun 14, 2023
Merged
@yahonda yahonda mentioned this pull request Jun 15, 2023
Closed
yahonda added a commit to yahonda/buildkite-config that referenced this pull request Jun 15, 2023
@yahonda
Use Debian 11 "bullseye" based Ruby Docker image
be78b6e 
This commit changes Ruby Docker images for 3.1 and 3.2
from Debian 12 "bookworm" based to Debian 11 "bullseye".

Until we address the root cause of rails/rails#48483

Refer to docker-library/ruby#415
@yahonda yahonda mentioned this pull request Jun 15, 2023
Merged
generalmimon added a commit to kaitai-io/kaitai_struct_visualizer that referenced this pull request Jul 23, 2023
@generalmimon
Dockerfile: use OpenJDK 17 and Ruby 3.2
47721ce 
The base `ruby` image dropped Debian 10 ("buster") images and converted
them to Debian 12 ("bookworm") - see
<docker-library/ruby#415>. However, while
OpenJDK 11 was available in "buster", it is no longer available in
"bookworm", so we now have to use OpenJDK 17 instead.
@yosifkit yosifkit mentioned this pull request Jan 2, 2024
Closed
atosbucket added a commit to atosbucket/rails-buildkit that referenced this pull request Mar 22, 2024
@atosbucket
Use Debian 11 "bullseye" based Ruby Docker image
11299f9 
This commit changes Ruby Docker images for 3.1 and 3.2
from Debian 12 "bookworm" based to Debian 11 "bullseye".

Until we address the root cause of rails/rails#48483

Refer to docker-library/ruby#415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojab ojab ojab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sitano @tianon @ojab @yosifkit