-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bullseye
& bullseye-slim
versions
#357
Conversation
in |
As in docker-library/python#633, this should also drop all traces of |
(You'll also need to update/run |
3adcfd4
to
5c29101
Compare
Done, CI is green except the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close, just a couple minor nits -- happy to take over from here if you'd prefer. 👍
versions.sh
Outdated
"buster", | ||
if env.rcVersion == "2.6" then | ||
"stretch" | ||
else empty end | ||
"bullseye" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be in the opposite order, and ought to have matching whitespace 😅
"buster", | |
if env.rcVersion == "2.6" then | |
"stretch" | |
else empty end | |
"bullseye" | |
"bullseye", | |
"buster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, whitespaces 🤦
So AFAIU we want bullseye to be the default one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes: - docker-library/ruby@301b52c: Merge pull request docker-library/ruby#357 from ojab/add_bullseye - docker-library/ruby@4916859: Add `bullseye` & `bullseye-slim` versions, drop `stretch` & `stretch-slim` - docker-library/ruby@fc5c093: Merge pull request docker-library/ruby#358 from infosiftr/confused - docker-library/ruby@e439599: Update patch file shasum
The latest Ruby Docker image upgraded from Debian to Bullseye: docker-library/ruby#357 Bullseye no longer supports Node v10.x, which cause NPM to not be installed, resulting in failing builds. As Node v10.x is no longer supported we should switch to a supported version. Active support for v14 ends in November 2021, so we might as well switch to v16. See: https://endoflife.date/nodejs Steps to reproduce: $ git clone https://github.com/rails/rails $ cd rails $ git clone https://github.com/rails/buildkite-config .buildkite/ $ RUBY_IMAGE=ruby:3.0.2 docker-compose -f .buildkite/docker-compose.yml build base && CI=1 docker-compose -f .buildkite/docker-compose.yml run actionview runner actionview 'rake test:ujs'
The latest Ruby Docker image upgraded from Debian to Bullseye: docker-library/ruby#357 Bullseye no longer supports Node v10.x, which cause NPM to not be installed, resulting in failing builds. As Node v10.x is no longer supported we should switch to a supported version. Active support for v14 ends in November 2021, so we might as well switch to v16. See: https://endoflife.date/nodejs Steps to reproduce: $ git clone https://github.com/rails/rails $ cd rails $ git clone https://github.com/rails/buildkite-config .buildkite/ $ RUBY_IMAGE=ruby:3.0.2 docker-compose -f .buildkite/docker-compose.yml build base && CI=1 docker-compose -f .buildkite/docker-compose.yml run actionview runner actionview 'rake test:ujs'
bullseye is out, let's add it.
Closes #356