-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributors #2143
Update contributors #2143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to remove the current contribution types? Were those going to be added back or automated in some way? Or are we no longer seeing any value in them?
I didn't considered this as very important. That's the drawback in favor of the automated listing of all code contributors. We still can add everyone to the "second list" with the all-contributors bot. So this possibility is still given if we want that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we somehow make sure that someone that gets added to "further contributors" is not already on the "normal" contributors.
I'm still not sure on this whole topic as the main benefit (showing on which topic someone contributed) gets lost / in the background (bc there are 200+ normal contributors in front).
We could rely on the github contributors list alone and have no effort at all.
651a335
I've no easier idea, how to handle this, as by looking first at the contributors before adding someone manually via bot.
Good point. Just "fixed" that. If you have a better description/phrasing, let me know and I'll happily change it 👍
I've worked on this PR, because I thought, based on the feedback + "thumbs up" in the maintainer discussion, there is consent (I may be wrong with that). At the end, it's a question of faith: To have one central place where we: I am the opinion with this "hybrid" model, it's a good compromise. I think all pro/cons have been mentioned in the maintainer discussion, so everyone can make a decision. To come to an end: @docker-mailserver/maintainers If you in general disagree with this approach at all and just want to leave it as it is right now, 👎 this post. |
I don't mind either way, as @wernerfred mentioned, we have official github repo stats on contributors which looks to be sorted by number of commits from contributors. All of us rank high on that and are visible. From what I understood, this automates the alternative contributors document that was setup, and still allows for making additions (such as different contribution badges) via the existing bot if desired. Sounds win/win to me 🤷♂️
I think the value is meant to be in stuff like the contribution type badges? This doesn't matter if you get buried, as long as you can easily The badges are one of the main differences from what Github officially provides. If we want a list of top contributors, we can use that instead. IIRC that wasn't sufficient for some when creating this contributors doc/section was discussed.
I don't recall exact reasons for this alternative document, but someone wanted to give contributors more recognition/visibility and introduced this. Then we had an issue about manually managing it and wanting to not leave out past contributors, so automation made sense? |
@wernerfred Is the current solution for you acceptable? I want to merge this the next days, if there is no veto from someone. |
Do it 🚀 |
Description
This combines two approaches to list all contributors.
@all-contributors
botType of change
Checklist:
docs/
)