-
Notifications
You must be signed in to change notification settings - Fork 177
WIP - Add --disable flag to render command #418
Conversation
Awesome! And this would resolve #396. 😄 |
c01951d
to
9685dce
Compare
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
- Coverage 60.4% 58.55% -1.86%
==========================================
Files 60 59 -1
Lines 3791 3378 -413
==========================================
- Hits 2290 1978 -312
+ Misses 1242 1140 -102
- Partials 259 260 +1
Continue to review full report at Codecov.
|
9685dce
to
4fbd53f
Compare
Any word on this one? If this gets merged, it’ll tweak and simplify some of my DockerCon talk (for the better). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can add a WithDisabledService
function, like WithName and add disabledServices
to the app
type, so you can remove it from the Render
signature.
f58e743
to
4978042
Compare
Adds a set/map of DisabledServices to App so they can be ignored by the render command. Signed-off-by: Ulysses Souza <ulyssessouza@docker.com>
4978042
to
a4015dd
Compare
Just added a test and refactored by adding a |
Sorry to keep poking, but wondering if this might be merged/released before DockerCon (I know there are probably a ton of other prep stuff you're all working on). We have a tool that builds on top of Docker App (mikesir87/devdock-node) that is using the old |
@mikesir87 Unfortunately we don't want to add any new features just before DockerCon so this is on hold. Looking forward to meeting you there in person! |
@chris-crone Ok! I'll go ahead and plan my slides using what currently exists, but then hint that a better way is in the works. Looking forward to seeing you there too! 🎉 |
Been a while since I've checked in here... any chance this might make it or will this feature just get dropped? |
Hello @mikesir87 , thanks for pinging us on this PR 👍 . |
Makes sense. Thanks @silvin-lubecki 👍 |
Adds a set/map with the services to be ignored by the render command.
All other usages of render.Render() just pass 'nil'.
Note that it's a WIP PR.
Maybe we could use a better name for the flag and use the concept of filtering for other concepts.
Closes #396
- What I did
Added the capability to remove services from the render by specifying them in the command line.
- How I did it
Added a new flag in the "render" command called "disable"
- How to verify it
Given an already existing application package that contains 3 services called "service1", "service2" and "service3" run:
Only "service3" should be rendered
- Description for the changelog
Add a flag to the render command and pass the service names collected through the render.Render to be filtered afterwards