Add command to remove application images #648

rumpl · 2019-09-27T15:07:45Z

- What I did

Added a new comand to remove application images, example:

$ docker app image ls
REPOSITORY TAG   APP NAME
my-app     1.0.0 voting-app
my-app     1.0.1 voting-app

$ docker app image rm my-app:1.0.0 my-app:1.0.1 my-app:2.0.0
Deleted: docker.io/library/my-app:1.0.0
Deleted: docker.io/library/my-app:1.0.1
Error: no such image docker.io/library/my-app:2.0.0

$ docker app image ls
REPOSITORY TAG APP NAME

- How I did it

The image rm command only remove the bundle from the bundle store, container images are not touched

- How to verify it

Look at the e2e test to see sample usage.

- Description for the changelog
New subcommand docker app image rm to remove a docker application from the local bundle store.

- A picture of a cute animal (not mandatory but encouraged)

silvin-lubecki · 2019-09-27T15:26:26Z

internal/store/bundle.go

@@ -97,6 +98,20 @@ func (b *bundleStore) List() ([]reference.Named, error) {
 	return references, nil
 }

+// Remove removes a bundle from the bundle store.
+func (b *bundleStore) Remove(ref reference.Named) error {
+	if _, err := b.Read(ref); err != nil {


What about using os.Stat(path) instead?

codecov · 2019-09-27T15:31:27Z

Codecov Report

❗ No coverage uploaded for pull request base (master@98cd1c5). Click here to learn what that means.
The diff coverage is 64.1%.

@@           Coverage Diff            @@
##             master    #648   +/-   ##
========================================
  Coverage          ?   71.8%           
========================================
  Files             ?      52           
  Lines             ?    2713           
  Branches          ?       0           
========================================
  Hits              ?    1948           
  Misses            ?     513           
  Partials          ?     252

Impacted Files	Coverage Δ
internal/commands/image/command.go	`100% <100%> (ø)`
internal/commands/image/rm.go	`57.14% <57.14%> (ø)`
internal/store/bundle.go	`69% <71.42%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cd1c5...3385987. Read the comment docs.

internal/commands/image/rm.go

internal/store/bundle.go

internal/commands/image/rm.go

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

silvin-lubecki

LGTM

eunomie

LGTM

thaJeztah · 2019-10-03T13:49:18Z

internal/commands/image/rm.go

+
+func rmCmd() *cobra.Command {
+	return &cobra.Command{
+		Use:   "rm [APP_IMAGE] [APP_IMAGE...]",


Sorry for the late reply, but could you add remove as alias for this?

Suggested change

Use: "rm [APP_IMAGE] [APP_IMAGE...]",

Use: "rm [APP_IMAGE] [APP_IMAGE...]",

Aliases: []string{"remove"},

Actually, let me open a quick PR

thaJeztah · 2019-10-03T14:13:59Z

internal/commands/image/rm.go

+		return err
+	}
+
+	fmt.Println("Deleted: " + ref.String())


Perhaps we should consistently use dockerCli.Out() / dockerCli.Err() for these; ideally we would print the reference on stdout, and Deleted: on stderr, but I don't think we do that currently on the CLI

GordonTheTurtle added the status/0-triage label Sep 27, 2019

silvin-lubecki changed the title ~~Add command to remove applicationh images~~ Add command to remove application images Sep 27, 2019