Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Add "remove" as alias for app image rm #662

Merged
merged 1 commit into from Oct 3, 2019

Conversation

thaJeztah
Copy link
Member

follow-up to #648

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@rumpl @silvin-lubecki

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #662 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   71.76%   71.89%   +0.12%     
==========================================
  Files          52       52              
  Lines        2646     2647       +1     
==========================================
+ Hits         1899     1903       +4     
+ Misses        502      500       -2     
+ Partials      245      244       -1
Impacted Files Coverage Δ
internal/commands/image/rm.go 62.5% <100%> (+1.2%) ⬆️
types/parameters/parameters.go 96.82% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8504449...631171a. Read the comment docs.

@glours glours merged commit 3731cd0 into docker:master Oct 3, 2019
@thaJeztah thaJeztah deleted the remove_alias branch October 3, 2019 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants