This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Add a json output as default for app inspect #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 52 52
Lines 2715 2715
=======================================
Hits 1952 1952
Misses 518 518
Partials 245 245Continue to review full report at Codecov.
|
glours
approved these changes
Oct 3, 2019
internal/commands/inspect.go
Outdated
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type inspectOptions struct { | ||
| parametersOptions | ||
| pullOptions | ||
| pretty bool | ||
| } | ||
|
|
||
| func inspectCmd(dockerCli command.Cli) *cobra.Command { | ||
| var opts inspectOptions | ||
| cmd := &cobra.Command{ | ||
| Use: "inspect [APP_NAME] [OPTIONS]", |
There was a problem hiding this comment.
@chris-crone What should we put here: [APP_NAME]? [APP_IMAGE]? [APP_INSTALLATION]? Both as inspect can be applied on installation or app image?
rumpl
force-pushed
the
feat-inspect
branch
3 times, most recently
from
d8c9ffb
to
98ccaaa
Compare
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Older bundles don't have the inspect format parameter, we don't set it for them, we set it only on bundles that define that parameter. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
ndeloof
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Made
docker app inspectprint a json by default, added a flag--prettyto print the old tabular inspect.- How I did it
- How to verify it
docker app bundle ... --tag my-app:1.0.0docker app inspect my-app:1.0.0- Description for the changelog
Docker app inspect now prints a json by default. Only bundled or running apps can be inspected.
- A picture of a cute animal (not mandatory but encouraged)
