-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: docker driver doesn't support auto-push #100
Comments
The error message will be more explicit in a further release. See docker/buildx#360.
I think it's better to separate the build part from the setup part. As would for example setup-go which only installs Golang. But thanks for your input, will consider that. |
I agree. I really like the decision to extract login and setup from v2. 👍 In this case, the environment is already set up to use the docker driver. I don't expect this action to change that setup. I do expect an action called Thanks for considering, and great work with v2 so far! |
Version 2 has been merged to the main branch and is therefore available via As a reminder, this new version changes drastically and works with 3 new actions (login, setup-buildx and setup-qemu) that we have created. Many usage examples have been added to handle most use cases. And it should fix this current issue. Don't hesitate if you have any questions. |
@crazy-max It doesn't look like this issue has been fixed yet. |
@ngraef Now the README with its examples clearly shows the use of |
The result is the same with the jobs:
build:
- uses: actions/checkout@v2
- uses: docker/setup-buildx-action@v1
with:
driver: docker
- uses: docker/login-action@v1
with:
registry: ${{ env.REGISTRY }}
username: ${{ env.USER }}
password: ${{ secrets.PASSWORD }}
- uses: docker/build-push-action@v2
with:
context: .
tags: ${{ env.REGISTRY }}/myapp:latest
push: true Again, I know this is an upstream limitation, but I believe it makes sense for |
Our goal is to avoid hacks around this action and be as closed as possible of the |
I'm ok with a hack in |
Surprised to find this closed, I also ran into this and was somewhat confused. Unfortunately I have to use the docker driver since multiple images in my build rely on "base" images being built on that same machine. Would definitely like to see this supported. |
@wbobeirne - same here. How are you using the docker driver? |
You have three possibilities atm (the first one being the more straightforward). With docker-container driver (via
|
wow, seems I started trying to use v2 to get rid of warning, did I miss anything?
|
* try extract data from builder in Dockerfile * tempororily build by commit * use . for container * revert the image name * separate builder from dockerfile * fix id conflicts * try with tag builder * explicit show from dockerfile * fix load * double load true here * use docker as dockerbuilderx driver * fix image tag * fix v2ray path from builder * push built image * manully push due to the driver not support auto-push ref: docker/build-push-action#100 * fix comment * add id for missing outputs * fix name for compile and build
Error: buildx call failed with: auto-push is currently not implemented for docker driver docker-build action is having open issue docker/build-push-action#100
Ubuntu virtual environments have been updated and now use Buildx 0.5.1 so it should be available through docker/buildx#442. |
To work around push error docker/build-push-action#100 (comment)
…ilize CI (#52) * Update package.json * Update package.json * Update upload.yml * Create Dockerfile * Update upload.yml docker/build-push-action#100 (comment) * Update upload.yml * temp work around * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update upload.yml * Update Dockerfile.alt * Update Dockerfile.alt * Update Dockerfile.alt * Update upload.yml * Update upload.yml * Update upload.yml * Update user_routes.cpp * Update Edit.js * Update Delete.js
In my case, I didn't use the github action, but saw the same issue. I fxed with adding below command before
|
Can we somehow rely on the caching if we use the docker driver or we have to drop it? |
I'm experimenting with the v2 branch and ran into an issue with the basic use case below. Notice it's using the default builder (no setup-buildx-action step) with the docker driver.
The output for the build step is:
I realize the error is coming from buildx upstream, but considering this action is called "build-push", I think users would expect this functionality to be implemented by the action if the underlying tool doesn't support it — or at least have a large warning in the README. My use case is more complex than this example, and part of the appeal of this action is that it seamlessly handles pushing a dynamic number of tags.
The text was updated successfully, but these errors were encountered: