-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warn about ignored inputs #1019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit otherwise LGTM.
Also run docker buildx bake pre-checkin
to update generated code like c66ae3a
52e0f98
to
2d7b2af
Compare
@crazy-max I believe all issues were addressed. 😀 |
Currently, several inputs can be silently ignored without any warnings. This change will issue a warning for each ignored input with a short explanation. Signed-off-by: favonia <favonia@gmail.com>
2d7b2af
to
8411d08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.1.0` -> `v5.2.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0) - Disable quotes detection for `outputs` input by [@​crazy-max](https://togithub.com/crazy-max) in [docker/build-push-action#1074 - Warn about ignored inputs by [@​favonia](https://togithub.com/favonia) in [docker/build-push-action#1019 - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.14.0 to 0.18.0 in [docker/build-push-action#1070 - Bump undici from 5.26.3 to 5.28.3 in [docker/build-push-action#1057 **Full Changelog**: docker/build-push-action@v5.1.0...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#700) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.1.0` -> `v5.2.0` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/docker/build-push-action/badge)](https://securityscorecards.dev/viewer/?uri=github.com/docker/build-push-action) | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0) - Disable quotes detection for `outputs` input by [@​crazy-max](https://togithub.com/crazy-max) in [docker/build-push-action#1074 - Warn about ignored inputs by [@​favonia](https://togithub.com/favonia) in [docker/build-push-action#1019 - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.14.0 to 0.18.0 in [docker/build-push-action#1070 - Bump undici from 5.26.3 to 5.28.3 in [docker/build-push-action#1057 **Full Changelog**: docker/build-push-action@v5.1.0...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/4m-mazi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Currently, several inputs can be silently ignored without any warnings. This PR will issue a warning for each ignored input with a short explanation. I actually complained about the silent input ignoring in other issues/PRs, but since this is an open-source project, I suppose I can just make a PR. 😄 If this PR is accepted, I also hope future ignore inputs will come with appropriate warnings.