Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add cgroup-parent support #814

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Conversation

crazy-max
Copy link
Member

follow-up #810 (comment)

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
go.mod Outdated Show resolved Hide resolved
build/build.go Outdated
FrontendAttrs: map[string]string{},
Frontend: "dockerfile.v0",
FrontendAttrs: map[string]string{
"cgroup-parent": opt.CgroupParent,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we should not check if cgroup-parent is already specified for a driver and in this case warn the user about it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they are strictly related.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not set it if empty as there is no nil value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes indeed will fix that

@crazy-max crazy-max added this to the v0.7.0 milestone Oct 27, 2021
@crazy-max crazy-max marked this pull request as ready for review October 28, 2021 11:21
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants