[WIP] Add new builder subcommand and implement builder prune to prune build cache
#1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild cache. This patch adds a new builder subcommand to manage builds, allowing to add more builder-related commands in the future. Unfortunately `build` expects an argument so could not be used as a subcommand. This also implements `docker builder prune`, which is needed to prune the builder cache manually without having to call `docker system prune`. Today when relying on the legacy builder, users are able to list a set of images (used as build cache) based on time filters and delete them. This patch allows the same usecase and more (specifying storage size) when relying on the new builder. The behavior of the `--all` option on `system prune` is slightly modified with respect to build cache: without `--all`, all but internal/frontend cache is removed whereas with `--all`, it removes the entirety of buildkit's cache. This is similar to keeping non-dangling images by default and removing them if `--all` is specified. Signed-off-by: Tibor Vass <tibor@docker.com>
vdemeester
added
status/1-design-review
status/needs-vendoring
and removed
status/0-triage
labels
thaJeztah
requested changes
Aug 16, 2018
| fmt.Fprintln(dockerCli.Out(), "Total reclaimed space:", units.HumanSize(float64(report.SpaceReclaimed))) | ||
| return nil | ||
| }, | ||
| Annotations: map[string]string{"version": "1.39"}, |
There was a problem hiding this comment.
Should we hide this command, based on if buildkit is enabled?
| @@ -42,7 +43,7 @@ func newPruneCommand(dockerCli command.Cli) *cobra.Command { | |||
|
|
|||
| flags := cmd.Flags() | |||
| flags.BoolVarP(&options.force, "force", "f", false, "Do not prompt for confirmation") | |||
| flags.BoolVarP(&options.all, "all", "a", false, "Remove all unused images not just dangling ones") | |||
| flags.BoolVarP(&options.all, "all", "a", false, "Remove all unused images not just dangling ones, as well as all internal build cache") | |||
There was a problem hiding this comment.
if --all is not set, do we prune any build cache at all?
(thinking about slightly different phrasing)
|
@tiborvass needs conflict resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: this modifies vendor
This patch adds a new builder subcommand to manage builds, allowing to add more
builder-related commands in the future. Unfortunately
buildexpects an argumentso could not be used as a subcommand.
This also implements
docker builder prune, which is needed to prune the buildercache manually without having to call
docker system prune.Today when relying on the legacy builder, users are able to list a set of images
(used as build cache) based on time filters and delete them. This patch allows the
same usecase and more (specifying storage size) when relying on the new builder.
The behavior of the
--alloption onsystem pruneis slightly modified withrespect to build cache: without
--all, all but internal/frontend cache is removedwhereas with
--all, it removes the entirety of buildkit's cache. This is similarto keeping non-dangling images by default and removing them if
--allis specified.Signed-off-by: Tibor Vass tibor@docker.com