builder: Implement builder prune to prune build cache
#1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild cache. This patch adds a new builder subcommand, allowing to add more builder-related commands in the future. Unfortunately `build` expects an argument so could not be used as a subcommand. This also implements `docker builder prune`, which is needed to prune the builder cache manually without having to call `docker system prune`. Today when relying on the legacy builder, users are able to prune dangling images (used as build cache) by running `docker image prune`. This patch allows the same usecase with buildkit. Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
cmd-builder-prune-no-options
branch
from
c535cac
to
f597f2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 54.03% 54.03%
=======================================
Files 272 272
Lines 18072 18072
=======================================
Hits 9766 9766
Misses 7690 7690
Partials 616 616 |
vdemeester
requested review from
dnephin,
vdemeester,
thaJeztah and
silvin-lubecki
|
LGTM I think it is best to get this simple version in first to enable cleanup while discussing what any filtering will look like in the API. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #1292 without any API changes to make it easier. It would still be better than forcing users to run
docker system prunewhich also removes stopped containers (undesirable side-effect).This patch adds a new builder subcommand, allowing to add more builder-related commands in the future. Unfortunately
buildexpects an argument so could not be used as a subcommand.This also implements
docker builder prune, which is needed to prune the builder cache manually without having to calldocker system prune.Today when relying on the legacy builder, users are able to prune dangling images (used as build cache) by running
docker image prune. This patch allows the same usecase with buildkit.Signed-off-by: Tibor Vass tibor@docker.com