Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy overlay storage driver #1425

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

thaJeztah
Copy link
Member

The overlay storage driver is deprecated in favor of the overlay2 storage
driver, which has all the benefits of overlay, without its limitations (excessive
inode consumption). The legacy overlay storage driver will be removed in a future
release. Users of the overlay storage driver should migrate to the overlay2
storage driver.

The legacy overlay storage driver allowed using overlayFS-backed filesystems
on pre 4.x kernels. Now that all supported distributions are able to run overlay2
(as they are either on kernel 4.x, or have support for multiple lowerdirs
backported), there is no reason to keep maintaining the overlay storage driver.

related issue in the documentation repository: docker/docs#7439

The `overlay` storage driver is deprecated in favor of the `overlay2` storage
driver, which has all the benefits of `overlay`, without its limitations (excessive
inode consumption). The legacy `overlay` storage driver will be removed in a future
release. Users of the `overlay` storage driver should migrate to the `overlay2`
storage driver.

The legacy `overlay` storage driver allowed using overlayFS-backed filesystems
on pre 4.x kernels. Now that all supported distributions are able to run `overlay2`
(as they are either on kernel 4.x, or have support for multiple lowerdirs
backported), there is no reason to keep maintaining the `overlay` storage driver.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #1425 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   54.27%   54.27%           
=======================================
  Files         289      289           
  Lines       19337    19337           
=======================================
  Hits        10496    10496           
  Misses       8165     8165           
  Partials      676      676

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@AkihiroSuda
Copy link
Collaborator

Can we have WARNING: overlay is deprecated in docker info?

@thaJeztah
Copy link
Member Author

Can we have WARNING: overlay is deprecated in docker info?

@AkihiroSuda yes, I was thinking of adding that

@AkihiroSuda
Copy link
Collaborator

Aside from this PR, can we deprecate AUFS as well?
(I thought we have already deprecated but seems not 😅 )

@thaJeztah
Copy link
Member Author

Yes, aufs could definitely be a candidate as well, now that support for Ubuntu 14.04 is dropped (which, I think was the only distro that actively used it)

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Collaborator

Warning can go in a separate PR, getting these docs in is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants