Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AuFS storage driver #1484

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 26, 2018

The aufs storage driver is deprecated in favor of overlay2, and will
be removed in a future release. Users of the aufs storage driver are
recommended to migrate to a different storage driver, such as overlay2, which
is now the default storage driver.

The aufs storage driver facilitates running Docker on distros that have no
support for OverlayFS, such as Ubuntu 14.04 LTS, which originally shipped with
a 3.14 kernel.

Now that Ubuntu 14.04 is no longer a supported distro for Docker, and overlay2
is available to all supported distros (as they are either on kernel 4.x, or have
support for multiple lowerdirs backported), there is no reason to continue
maintenance of the aufs storage driver.

- Description for the changelog

* Deprecate `aufs` storage driver [docker/cli#1484](https://github.com/docker/cli/pull/1484)

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

ping @dhiltgen @vdemeester @dmcgowan

@AkihiroSuda as we were discussing in #1425 (comment)

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #1484 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files         310      310           
  Lines       21801    21801           
=======================================
  Hits        12370    12370           
  Misses       8517     8517           
  Partials      914      914

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Collaborator

Is this going to be merged to v18.09?

@thaJeztah thaJeztah changed the title Deprecate AuFS storage driver [WIP] Deprecate AuFS storage driver Nov 5, 2018
@thaJeztah
Copy link
Member Author

Let me mark this "WIP" for now; there were concerns about AuFS still being too widely in use to mark it deprecated already 😕

@cpuguy83
Copy link
Collaborator

cpuguy83 commented Nov 5, 2018

What's the concern in just marking it deprecated? It's not a removal.

The `aufs` storage driver is deprecated in favor of `overlay2`, and will
be removed in a future release. Users of the `aufs` storage driver are
recommended to migrate to a different storage driver, such as `overlay2`, which
is now the default storage driver.

The `aufs` storage driver facilitates running Docker on distros that have no
support for OverlayFS, such as Ubuntu 14.04 LTS, which originally shipped with
a 3.14 kernel.

Now that Ubuntu 14.04 is no longer a supported distro for Docker, and `overlay2`
is available to all supported distros (as they are either on kernel 4.x, or have
support for multiple lowerdirs backported), there is no reason to continue
maintenance of the `aufs` storage driver.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title [WIP] Deprecate AuFS storage driver Deprecate AuFS storage driver Jul 2, 2019
@thaJeztah
Copy link
Member Author

Updated to reflect that it's in 19.03, not 18.09

@thaJeztah thaJeztah changed the title Deprecate AuFS storage driver [WIP] Deprecate AuFS storage driver Jul 2, 2019
@andrewhsu
Copy link
Contributor

Long time coming since we have had overlay2 as the default for quite some time. This PR LGTM especially for the master branch which represents our upcoming releases.

@thaJeztah thaJeztah changed the title [WIP] Deprecate AuFS storage driver Deprecate AuFS storage driver Jul 2, 2019
@thaJeztah thaJeztah merged commit 39e22d9 into docker:master Jul 2, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Jul 2, 2019
@thaJeztah thaJeztah deleted the deprecate_aufs branch July 2, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants