New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker invalid-subcommand
regression
#1429
Fix docker invalid-subcommand
regression
#1429
Conversation
Starting with a3fe7d6, `docker invalid-subcommand` did not exit with non-zero status. Fix docker#1428 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 54.22% 54.23% +<.01%
==========================================
Files 289 289
Lines 19359 19362 +3
==========================================
+ Hits 10498 10501 +3
+ Misses 8185 8183 -2
- Partials 676 678 +2 |
@AkihiroSuda wondering if we should have a fix for this upstream in cobra |
Oh, actually, I see it's on our side |
@thaJeztah @cpuguy83 PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 馃惎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
whoops, thought I LGTM'd already 馃槉
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
- What I did
Starting with a3fe7d6 (#1069),
docker invalid-subcommand
did not exit with non-zero status.Fix #1428
- How I did it
Restored
RunE
- How to verify it
- Description for the changelog
Fix
docker invalid-subcommand
regression- A picture of a cute animal (not mandatory but encouraged)
馃惂