Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for docker network create --ingress #239

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jun 24, 2017

This adds bash completion for moby/moby#31714.
Ping @sdurrheimer for zsh completion

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link

codecov-io commented Jun 24, 2017

Codecov Report

Merging #239 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #239      +/-   ##
=========================================
+ Coverage   47.19%   47.2%   +<.01%     
=========================================
  Files         171     171              
  Lines       11556   11556              
=========================================
+ Hits         5454    5455       +1     
+ Misses       5791    5790       -1     
  Partials      311     311

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 993b78d into docker:master Jun 30, 2017
@albers albers deleted the completion-network-create--ingress branch June 30, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants