-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ulimits support to docker service and docker stack deploy (carry 2660) #2712
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This is related to moby/moby 40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
--ulimit-add | ||
--ulimit-rm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the zsh script as well, but might do so in a follow-up
--ulimit-add ulimit Add or update a ulimit option (default []) | ||
--ulimit-rm list Remove a ulimit option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because one uses a regular "list" and the other uses a ulimit option, the output for these flags is inconsistent (ulimit
vs list
); probably something we should fix somehow; not sure what's best
Codecov Report
@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
+ Coverage 58.54% 58.56% +0.02%
==========================================
Files 296 296
Lines 21286 21345 +59
==========================================
+ Hits 12462 12501 +39
- Misses 7915 7931 +16
- Partials 909 913 +4 |
This is related to moby/moby 40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
8d4ec82
to
9409079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bash completion LGM.
I'll create a follow-up PR that adds completion for the limits.
Hi team, |
@vindhya2g You need to upgrade docker to 20.10. |
Thank you |
carries #2660
closes #2660
- What I did
Bump docker/docker to my own fork to have API changes regarding ulimits support on service endpoints ;--ulimit
todocker service create
;--ulimit-add
and--ulimit-rm
options todocker service update
;Ulimits
todocker service inspect --pretty
;docker stack deploy
;This is related to moby/moby#40639.
- How I did it
- How to verify it
Given the following
docker-compose.yaml
:docker service create
docker service update
docker service inspect
docker stack deploy
- Description for the changelog
Add
ulimits
support todocker service create|update|inspect
anddocker stack deploy
- A picture of a cute animal (not mandatory but encouraged)