contrib/completion: remove "compose on kubernetes" flags zsh completion #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
Feb 24, 2022
thaJeztah
commented
- Follow up to Drop support for (archived) Compose-on-Kubernetes #3139
- Addresses Drop Kubernetes support (compose-on-kubernetes is now unmaintained & archived) #2967
Codecov Report
@@ Coverage Diff @@
## master #3439 +/- ##
=======================================
Coverage 59.48% 59.48%
=======================================
Files 287 287
Lines 24182 24182
=======================================
Hits 14385 14385
Misses 8931 8931
Partials 866 866 |
albers
reviewed
Feb 27, 2022
There was a problem hiding this comment.
Bash completion LGTM. I found some nits regarding consistency.
Keeping the $options variables instead of inlining them probably improves readybility.
But the existing code only uses such variables where option lists are constructed incrementally, so for consistency I recommend to remove them.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
drop_kube_completion
branch
from
7251b17
to
2d74be8
Compare
thaJeztah
changed the title
thaJeztah
commented
May 1, 2022
|
@albers rebased this one, and removed the bash completion changes (spotted one variable we missed); ptal |
albers
approved these changes
May 2, 2022
|
hehe, neither am I, but I think removing those lines should be "good". Thanks for looking; let me get this one in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.