Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash completion for deprecated orchestrator flags #3578

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

See 039018b for corresponding docs change.

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #3578 (6712447) into master (1497633) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3578   +/-   ##
=======================================
  Coverage   59.36%   59.36%           
=======================================
  Files         287      287           
  Lines       24175    24175           
=======================================
  Hits        14352    14352           
  Misses       8958     8958           
  Partials      865      865           

@thaJeztah
Copy link
Member

❤️ Thanks!! I marked this PR as "replaces/closes" #3439, which I never got round to addressing your comments (😓); gave it a try, and looks to be working as expected 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit e3eedd3 into docker:master Apr 30, 2022
@albers
Copy link
Collaborator Author

albers commented Apr 30, 2022

Thanks @thaJeztah.
I found the deprecated options when working on #3577 and I had completely forgotten #3439.

But my PR only covers bash completion, so maybe you could carry the zsh part of #3439?

@albers albers deleted the completion-remove-orchestrator branch April 30, 2022 18:35
@thaJeztah
Copy link
Member

Ah, good one; yes, let me reopen that one, and only include the zsh commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants