introduce context show command
#3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
approved these changes
Apr 25, 2022
thaJeztah
requested changes
Apr 25, 2022
There was a problem hiding this comment.
Left some comments.
Now that we have the docker context show command, perhaps we should
- add a
docs/reference/context_show.mdfile - move the examples from https://github.com/docker/cli/pull/2500/files#diff-3589954942dcb3aa5aa11ca30bee4e904ebd9c35d1d9dfa73192f1655cdc5250R81
- (or keep the heading that's there, and link to the
context showreference)
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 58.99% 58.98% -0.02%
==========================================
Files 282 285 +3
Lines 23813 23834 +21
==========================================
+ Hits 14049 14058 +9
- Misses 8908 8920 +12
Partials 856 856 |
ndeloof
force-pushed
the
context_show
branch
2 times, most recently
from
c6b1518
to
e7fe22f
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3425
- What I did
introduce
context showcommand, aligned with same command introduce in compose-cli- How I did it
new cobra command, dump current context name after checking it exists
- How to verify it
docker context show- Description for the changelog
introduce
docker context showcommand- A picture of a cute animal (not mandatory but encouraged)
