Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/docker/docker cb01202de88e20d5699c76efe948dfb065da873f #3635

Merged
merged 1 commit into from
May 28, 2022

Conversation

thaJeztah
Copy link
Member

no changes in vendored code other than a typo-fix, just aligning with latest master

moby/moby@8abb84c...cb01202

- A picture of a cute animal (not mandatory but encouraged)

…873f

no changes in vendored code other than a typo-fix, just aligning with latest master

moby/moby@8abb84c...cb01202

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #3635 (73c6231) into master (1496274) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3635   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files         289      289           
  Lines       24625    24625           
=======================================
  Hits        14534    14534           
  Misses       9218     9218           
  Partials      873      873           

@thaJeztah
Copy link
Member Author

Looks like we have a new flaky test; I'm guessing something is using a map, and therefore randomized by Go. Introduced in #3606

--- FAIL: TestVolumeCreateClusterOpts (0.00s)
    create_test.go:195: assertion failed: 
        --- body
        +++ expectedBody
          volume.CreateOptions{
          	ClusterVolumeSpec: &volume.ClusterVolumeSpec{
          		... // 2 identical fields
          		AccessibilityRequirements: &{Requisite: {{Segments: {"region": "R1", "zone": "Z1"}}, {Segments: {"region": "R1", "zone": "Z2"}}, {Segments: {"region": "R1", "zone": "Z3"}}}, Preferred: {{Segments: {"region": "R1", "zone": "Z2"}}, {Segments: {"region": "R1", "zone": "Z3"}}}},
          		CapacityRange:             &{RequiredBytes: 1234, LimitBytes: 567890},
          		Secrets: []volume.Secret{
        - 			{Key: "key2", Secret: "secret2"},
          			{Key: "key1", Secret: "secret1"},
        + 			{Key: "key2", Secret: "secret2"},
          		},
          		Availability: "active",
          	},
          	Driver:     "csi",
          	DriverOpts: {},
          	... // 2 identical fields
          }

@thaJeztah
Copy link
Member Author

Bringing this one one

@thaJeztah thaJeztah merged commit 84b86e2 into docker:master May 28, 2022
@thaJeztah thaJeztah deleted the update_engine branch May 28, 2022 22:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants