Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for service scale --detach #382

Merged
merged 1 commit into from Aug 1, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jul 26, 2017

This adds bash completion for #243.
This should go into 17.07 as the feature is present in that release.
Ping @sdurrheimer for zsh completion

Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers force-pushed the completion-service-scale--detach branch from f81f5e8 to 29d0f86 Compare July 27, 2017 12:43
@codecov-io
Copy link

codecov-io commented Jul 27, 2017

Codecov Report

Merging #382 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   46.14%   46.13%   -0.01%     
==========================================
  Files         193      193              
  Lines       16073    16073              
==========================================
- Hits         7417     7416       -1     
- Misses       8269     8270       +1     
  Partials      387      387

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@thaJeztah thaJeztah merged commit a74e213 into docker:master Aug 1, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 1, 2017
@thaJeztah thaJeztah modified the milestones: 17.07.0, 17.08.0 Aug 1, 2017
@albers albers deleted the completion-service-scale--detach branch August 2, 2017 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants