New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `--detach` to docker scale #243

Merged
merged 2 commits into from Jul 4, 2017

Conversation

Projects
None yet
7 participants
@vieux
Contributor

vieux commented Jun 27, 2017

depends on #219

fixes moby/moby#32368

@vieux vieux changed the title from Scale2 to add --detach to docker scale Jun 27, 2017

@vieux vieux changed the title from add --detach to docker scale to add `--detach` to docker scale Jun 27, 2017

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jun 27, 2017

Contributor

@thaJeztah not sure how to add the completion scripts here, I don't see --detach for the other service commands

Contributor

vieux commented Jun 27, 2017

@thaJeztah not sure how to add the completion scripts here, I don't see --detach for the other service commands

Show outdated Hide outdated cli/command/service/scale.go Outdated
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 27, 2017

Member

CI is failing;

cli/command/service/helpers_test.go:7: testing redeclared as imported package name
	previous declaration at cli/command/service/helpers_test.go:5
FAIL	github.com/docker/cli/cli/command/service [build failed]
Member

thaJeztah commented Jun 27, 2017

CI is failing;

cli/command/service/helpers_test.go:7: testing redeclared as imported package name
	previous declaration at cli/command/service/helpers_test.go:5
FAIL	github.com/docker/cli/cli/command/service [build failed]
add --detach to docker scale
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 27, 2017

Codecov Report

Merging #243 into master will decrease coverage by 1.65%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   48.44%   46.78%   -1.66%     
==========================================
  Files         173      172       -1     
  Lines       11748    11706      -42     
==========================================
- Hits         5691     5477     -214     
- Misses       5696     5917     +221     
+ Partials      361      312      -49

codecov-io commented Jun 27, 2017

Codecov Report

Merging #243 into master will decrease coverage by 1.65%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   48.44%   46.78%   -1.66%     
==========================================
  Files         173      172       -1     
  Lines       11748    11706      -42     
==========================================
- Hits         5691     5477     -214     
- Misses       5696     5917     +221     
+ Partials      361      312      -49
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jun 27, 2017

Contributor

@thaJeztah PTAL

Contributor

vieux commented Jun 27, 2017

@thaJeztah PTAL

@vdemeester

LGTM 🦁

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jun 27, 2017

Collaborator

Thanks. It would also be great to add this flag to docker stack deploy. There has been a lot of interest in that: moby/moby#32367. I see @vdemeester assigned this to himself.

Collaborator

aaronlehmann commented Jun 27, 2017

Thanks. It would also be great to add this flag to docker stack deploy. There has been a lot of interest in that: moby/moby#32367. I see @vdemeester assigned this to himself.

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jun 30, 2017

Contributor

@dnephin @vdemeester how about this ? (I kept it simple)

Contributor

vieux commented Jun 30, 2017

@dnephin @vdemeester how about this ? (I kept it simple)

@vdemeester

LGTM 🐮

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jun 30, 2017

Contributor

I understand it's not a perfect solution, but I think it's OK for now.

Contributor

vieux commented Jun 30, 2017

I understand it's not a perfect solution, but I think it's OK for now.

@dnephin

Just one question

Show outdated Hide outdated cli/command/service/scale.go Outdated
scale all services at once
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jul 4, 2017

Contributor

@dnephin PTAL

Contributor

vieux commented Jul 4, 2017

@dnephin PTAL

@dnephin

dnephin approved these changes Jul 4, 2017

LGTM

@vieux vieux merged commit 43fb4a4 into docker:master Jul 4, 2017

6 of 7 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 46.78% (-1.66%) compared to 379b762
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 4, 2017

@vieux vieux deleted the vieux:scale2 branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment