docker info: don't print "registry" (IndexServerAddress) #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IndexServerAddress field was as part of the initial Windows implementation of the engine. For legal reasons, Microsoft Windows (and thus Docker images based on Windows) were not allowed to be distributed through non-Microsoft infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io" registry was created to serve Windows images. Currently, this field always shows "https://index.docker.io/v1/", which is confusing, because that address is not used for the registry (only for authentication and "v1" search). docker info ... Registry: https://index.docker.io/v1/ Starting with b4ca1c7, this field is also no longer used during authentication, and a3d56e7 removed the (deprecated) ElectAuthServer() which was previously used to query it. Given that there's currently no practical use for this information, and it only adds "noise" (and confusion), this patch removes it from the default output. For now, the field is (still) available for those that want to use it; docker info --format '{{.IndexServerAddress}}' https://index.docker.io/v1/ But it won't be printed by default. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4204 +/- ##
==========================================
- Coverage 58.86% 58.86% -0.01%
==========================================
Files 572 572
Lines 49546 49544 -2
==========================================
- Hits 29164 29162 -2
Misses 18616 18616
Partials 1766 1766 |
vvoland
approved these changes
Apr 13, 2023
|
We can remove the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IndexServerAddress field was as part of the initial Windows implementation of the engine. For legal reasons, Microsoft Windows (and thus Docker images based on Windows) were not allowed to be distributed through non-Microsoft infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io" registry was created to serve Windows images.
Currently, this field always shows "https://index.docker.io/v1/", which is confusing, because that address is not used for the registry (only for authentication and "v1" search).
Starting with b4ca1c7, this field is also no longer used during authentication, and a3d56e7 removed the (deprecated) ElectAuthServer() which was previously used to query it.
Given that there's currently no practical use for this information, and it only adds "noise" (and confusion), this patch removes it from the default output.
For now, the field is (still) available for those that want to use it;
But it won't be printed by default.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)