cli: move "config" flag to cli/flags/ClientOptions.InstallFlags() #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4388 +/- ##
=======================================
Coverage 59.36% 59.37%
=======================================
Files 288 288
Lines 24748 24747 -1
=======================================
+ Hits 14692 14693 +1
+ Misses 9172 9170 -2
Partials 884 884 |
This flag was kept separate from the other flags, because at the time, the CLI code and Daemon code still used the same codebase, and shared some parts. This option only applied to the `docker` CLI, and thus was kept separate when migrating to Cobra in moby/moby@0452ff5 Now that this code is only used for the CLI (and plugins), we can move this flag together with the other flags. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
move_config_flag
branch
from
90bc986
to
3cad05f
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was kept separate from the other flags, because at the time, the CLI code and Daemon code still used the same codebase, and shared some parts. This option only applied to the
dockerCLI, and thus was kept separate when migrating to Cobra in moby/moby@0452ff5 (moby/moby#25354)Now that this code is only used for the CLI (and plugins), we can move this flag together with the other flags.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)