Convert docker and dockerd commands to spf13/cobra #25354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
2 times, most recently
from
eb1d84e
to
6fe55a3
Compare
|
@dnephin Test failures seem related. |
tonistiigi
added
the
status/failing-ci
|
I think they are related. Having some trouble finding the cause, but still working on it. |
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
from
6fe55a3
to
ba1daa8
Compare
GordonTheTurtle
added
the
dco/no
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
from
ba1daa8
to
954de5c
Compare
GordonTheTurtle
removed
the
dco/no
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
2 times, most recently
from
4a90e29
to
40c3a15
Compare
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
7 times, most recently
from
8f09eac
to
2b83d17
Compare
dnephin
removed
the
status/failing-ci
|
This is green! |
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
2 times, most recently
from
76d3804
to
1357c1e
Compare
| @@ -4,12 +4,22 @@ package main | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/spf13/cobra" | |||
There was a problem hiding this comment.
nit: this import is misplaced 👼
|
LGTM 🐸 |
|
LGTM |
Support command traversal Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Fix the daemon proxy for cobra commands. Signed-off-by: Daniel Nephin <dnephin@docker.com>
Improve error messages raised by assert. Signed-off-by: Daniel Nephin <dnephin@docker.com>
Cleanup cobra integration Update windows files for cobra and pflags Cleanup SetupRootcmd, and remove unnecessary SetFlagErrorFunc. Use cobra command traversal Signed-off-by: Daniel Nephin <dnephin@docker.com>
Also consolidate the leftover packages under cli. Remove pkg/mflag. Make manpage generation work with new cobra layout. Remove remaining mflag and fix tests after rebase with master. Signed-off-by: Daniel Nephin <dnephin@docker.com>
dnephin
force-pushed
the
remove-mflag-from-dockerd
branch
from
1357c1e
to
6e7405e
Compare
Support args to RunCommand Fix docker help text test. Fix for ipv6 tests. Fix TLSverify option. Fix TestDaemonDiscoveryBackendConfigReload Use tempfile for another test. Restore missing flag. Fix tests for removal of shlex. Signed-off-by: Daniel Nephin <dnephin@docker.com>
This was referenced Aug 26, 2016
You bet! We just did. |
|
This is breaking master, with this ExecStart (note using the compat I'm getting: This has somehow broke the old |
|
@dnephin can we also add a test which uses |
|
@runcom ok, i'll take a look, and add the missing test. i thought we had one for that. |
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23211
Fixes #25547
pkg/mflagcli/and consolidates the rest of the package into fewer files