vendor: migrate to github.com/go-viper/mapstructure/v2 v2.0.0 #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4744 +/- ##
=======================================
Coverage 61.37% 61.37%
=======================================
Files 298 298
Lines 20717 20717
=======================================
Hits 12715 12715
Misses 7102 7102
Partials 900 900 |
thaJeztah
force-pushed
the
migrate_mapstructure
branch
from
6e00963
to
39c9ebc
Compare
thaJeztah
force-pushed
the
migrate_mapstructure
branch
from
39c9ebc
to
dafb92b
Compare
thaJeztah
changed the title
github.com/mitchellh/mapstructure will no longer be maintained by the author, and github.com/go-viper/mapstructure is nominated as the endorsed fork. - v1.x changes since last release from mitchellh: go-viper/mapstructure@v1.5.0...v1.6.0 - v2.0 changes: go-viper/mapstructure@v1.6.0...v2.0.0 Breaking changes Error is removed in favor of errors.Join (backported from Go 1.20 to preserve compatibility with earlier versions) What's Changed - feat!: update module path - build: update dev env - feature: add StringToBasicTypeHookFunc and support complex - Add an example showing how to use a DecodeHookFunc to parse a custom field. - Remove exposed error type - Replace internal joined error with errors.Join Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
migrate_mapstructure
branch
from
dafb92b
to
bc2e274
Compare
Benehiko
approved these changes
Jun 6, 2024
krissetto
reviewed
Jun 6, 2024
| @@ -171,9 +173,8 @@ github.com/matttproud/golang_protobuf_extensions v1.0.4/go.mod h1:BSXmuO+STAnVfr | |||
| github.com/miekg/pkcs11 v1.0.3/go.mod h1:XsNlhZGX73bx86s2hdc/FuaLm2CPZJemRLMA+WTFxgs= | |||
| github.com/miekg/pkcs11 v1.1.1 h1:Ugu9pdy6vAYku5DEpVWVFPYnzV+bxB+iRdbuFSu7TvU= | |||
| github.com/miekg/pkcs11 v1.1.1/go.mod h1:XsNlhZGX73bx86s2hdc/FuaLm2CPZJemRLMA+WTFxgs= | |||
| github.com/mitchellh/mapstructure v1.0.0 h1:vVpGvMXJPqSDh2VYHF7gsfQj8Ncx+Xw5Y1KHeTRY+7I= | |||
There was a problem hiding this comment.
🤔 why is this 1.0.0 version still here?
There was a problem hiding this comment.
Looks like it's Notary that still has it somewhere listed;
go mod graph | grep ' github.com/mitchellh/mapstructure'
github.com/theupdateframework/notary@v0.7.1-0.20210315103452-bf96a202a09a github.com/mitchellh/mapstructure@v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/mitchellh/mapstructure will no longer be maintained by the author,
and github.com/go-viper/mapstructure is nominated as the endorsed fork.
Breaking changes
Error is removed in favor of errors.Join (backported from Go 1.20 to preserve
compatibility with earlier versions)
What's Changed
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)