Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/list: Add --tree flag #4982

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Apr 4, 2024

Add --tree flag to docker image list

image

- Description for the changelog

- containerd image store:  `docker image ls` now supports `--tree` flag that shows a multiplatform-aware image list. This is experimental and may change at any time without any backwards compatibility.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 1.42857% with 138 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (b83cf58) to head (9cf3aac).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4982      +/-   ##
==========================================
+ Coverage   61.29%   61.34%   +0.04%     
==========================================
  Files         294      298       +4     
  Lines       20773    20921     +148     
==========================================
+ Hits        12733    12834     +101     
- Misses       7123     7172      +49     
+ Partials      917      915       -2     

func runTree(ctx context.Context, dockerCLI command.Cli, opts treeOptions) error {
images, err := dockerCLI.Client().ImageList(ctx, imagetypes.ListOptions{
All: opts.all,
ContainerCount: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvoland vvoland force-pushed the c8d-multiplatform-list branch 2 times, most recently from 4662670 to 6ec9439 Compare June 5, 2024 10:15
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/ux containerd-integration Issues and PRs related to containerd integration impact/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants