Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make buildx build the canonical reference doc #5002

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 10, 2024

- What I did

Move common flag descriptions to the buildx build reference, and make
that page the canonical page in docs. Also rewrite some content in
image_build to make clear that this page is only for the legacy builder.

Relates to:

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.44%. Comparing base (0340921) to head (e91f0de).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5002      +/-   ##
==========================================
+ Coverage   61.42%   61.44%   +0.01%     
==========================================
  Files         298      298              
  Lines       20798    20805       +7     
==========================================
+ Hits        12776    12783       +7     
  Misses       7109     7109              
  Partials      913      913              

@dvdksn dvdksn marked this pull request as ready for review April 23, 2024 09:24
@dvdksn dvdksn requested a review from thaJeztah as a code owner April 23, 2024 09:24
@dvdksn
Copy link
Contributor Author

dvdksn commented May 6, 2024

@dvdksn dvdksn requested a review from a team as a code owner July 2, 2024 14:05
Move common flag descriptions to the buildx build reference, and make
that page the canonical page in docs. Also rewrite some content in
image_build to make clear that this page is only for the legacy builder.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland added this to the 28.0.0 milestone Jul 3, 2024
@dvdksn dvdksn modified the milestones: 28.0.0, 27.0.4 Jul 3, 2024
@dvdksn dvdksn merged commit 1dee86b into docker:master Jul 4, 2024
97 checks passed
@dvdksn dvdksn deleted the buildx_build_canonical branch July 4, 2024 07:07
@dvdksn dvdksn modified the milestones: 27.0.4, 28.0.0 Jul 4, 2024
@dvdksn
Copy link
Contributor Author

dvdksn commented Jul 4, 2024

I wanted to cherrypick to 27.0 but seems like a bit of a mess, so leaving it for 28. I should still be able to vendor docs from master.

never mind, backport here: #5227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants