Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: make buildx build the canonical build #19774

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Apr 10, 2024

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/build Relates to Dockerfiles or docker build command area/get-started Relates to get started and onboarding docs labels Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit f7ccee3
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6696441bf9372f0008a6194e
😎 Deploy Preview https://deploy-preview-19774--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn
Copy link
Collaborator Author

dvdksn commented Apr 10, 2024

@thaJeztah @crazy-max I started looking at making buildx build the canonical CLI reference page for docker build, and repurposing the prevous docker [image] build page to cover only the legacy builder.

@crazy-max
Copy link
Member

@thaJeztah @crazy-max I started looking at making buildx build the canonical CLI reference page for docker build, and repurposing the prevous docker [image] build page to cover only the legacy builder.

Should we also duplicate/copy related reference docs missing in https://github.com/docker/buildx/blob/master/docs/reference/buildx_build.md?

Edit: nevermind docker/buildx#2397

@dvdksn
Copy link
Collaborator Author

dvdksn commented Apr 10, 2024

I pretty much just moved the flag descriptions for things like --build-arg without touching them. Might need to update some things.

Wondering if we should use docker build or docker buildx build in the examples on the Buildx reference page after this.

@dvdksn
Copy link
Collaborator Author

dvdksn commented Apr 10, 2024

Also this diff is showing what's on master for buildx, so not appropriate for merging here, just included to show what it will look like. Will need to backport to 0.13 branch if we want to release before 0.14. Maybe easier to do after that release.

@crazy-max
Copy link
Member

Wondering if we should use docker build or docker buildx build in the examples on the Buildx reference page after this.

I think using canonical docker buildx build would be better in GitHub markdown

aevesdocker
aevesdocker previously approved these changes Jul 11, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn merged commit 0772f90 into docker:main Jul 16, 2024
12 checks passed
@dvdksn dvdksn deleted the buildx_build_canonical branch July 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command area/get-started Relates to get started and onboarding docs area/hub Issue affects Docker Hub status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants