Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort secrets and configs to ensure idempotence #509

Merged
merged 1 commit into from
Sep 15, 2017
Merged

sort secrets and configs to ensure idempotence #509

merged 1 commit into from
Sep 15, 2017

Commits on Sep 8, 2017

  1. sort secrets and configs to ensure idempotence 

    `docker stack deploy` keeps restarting services it doesn't need to (no changes)
because the entries' order gets randomized at some previous (de)serialization.
Maybe it would be worth looking into this at a higher level and ensure
all (de)serialization happens in an ordered collection.

This quick fix sorts secrets and configs (in place, mutably) which ensures the
same order for each run.

Based on
moby/moby#30506

Fixes
moby/moby#34746

Signed-off-by: Peter Nagy <xificurC@gmail.com>
    pnagy committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    27e8bdf View commit details
    Browse the repository at this point in the history