Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: global force exit #5182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Benehiko
Copy link
Member

- What I did

Testing global signal handling in the CLI.

- How I did it

Reusing go test to execute some parts of the CLI and verify the exit code on SIGINT.

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (b83cf58) to head (dddf757).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5182      +/-   ##
==========================================
+ Coverage   61.29%   61.78%   +0.49%     
==========================================
  Files         294      297       +3     
  Lines       20773    20781       +8     
==========================================
+ Hits        12733    12840     +107     
+ Misses       7123     7027      -96     
+ Partials      917      914       -3     

@Benehiko
Copy link
Member Author

Benehiko commented Jul 4, 2024

Seems like I forgot to squash the commits on this PR, which lead to this being committed into master and then subsequently removed in a follow-up commit 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants